• src/conio/cterm.c

    From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Oct 12 11:05:11 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/bb233b89b205ae98af9eacb6
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Continue fixing a coverity issue.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Dec 22 23:35:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/1e9dcf477a5de94298f9bb74
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Clamp sixel repeat to 0x7fff per specification.

    This is the issue behind CVE-2022-24130 in xterm.
    Reported against SyncTERM by Autumn Lamonte (Thanks!)
    Discussion here: https://gitlab.com/klamonte/jexer/-/issues/105

    Closes SyncTERM bug 79.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Mon May 15 11:48:25 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/5c12fc2e5c7362a36fd68c23
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Fix memory leak and uninitialized acces in sixel graphics.

    Properly initialize sixel mask width/height.
    Free sx_mask->bits when finished.

    These were broken by the PPM feature commit 4975b41

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wed May 31 13:27:51 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/cda7525d78b0948996c19561
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Fix off-by-one in delete lines

    Previously, delete lines would erase the line above the current one.
    This was visible in vim which makes extensive use of delete line
    to scroll.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Fri Jun 9 11:24:59 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/e5c75c3a8268961c2552edb9
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Add comments to hopefully shut up Coverity

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Mon Jun 26 20:24:21 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/80379e9161895f4241bc30f3
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Fix warning: `end' may be used uninitialized in this function

    Fix multiple warning: ignoring return value of `asprintf'
    declared with attribute `warn_unused_result'

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Jun 28 10:01:38 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/1181333075e9674aad79ff3e
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Fix for 80379e916

    The commit just the zero-length behaviour from uninitialized use
    with possible undefined behaviour to guaranteed undefined behaviour.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Sat Feb 10 22:28:17 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/2f436df7f1606aa07ca81b1a
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Fix macro recusion protection for macros 32-63.

    Found by MSVC

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Sun Feb 11 13:43:18 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6621c97c34e6e1f193e45bb3
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Disable MSVC warnings 4244 and 4267.

    The alternative is to explicitly copy/paste the type everywhere
    forcing the compiler to do the only thing it could possibly do,
    and making it painful to change a type later.

    Honestly, in my opinion, these warnings should just be disabled
    completely everywhere.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Sun Feb 18 17:38:55 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/21c6201278ed7f0b9ee5f45e
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Fix doorway mode.

    CSI=255h was not entering doorway mode anymore.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Feb 22 06:50:40 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/dc2b586763a0c4a1be105efa
    Modified Files:
    src/conio/cterm.c
    Log Message:
    Use default instead of enum value in warning suppression.

    This will hopefully keep both Coverity and compilers happy.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net